-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media3P: Add hardening for missing media URLs #12091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timarney
added
Group: Media
Group: 3P Media
Third-party media provider integrations.
Type: Bug
Something isn't working
Pod: WP
labels
Aug 9, 2022
swissspidy
reviewed
Aug 10, 2022
…3p.js Co-authored-by: Pascal Birchler <pascalb@google.com>
@swissspidy I added a trackError to help surface anything that might come up in the future. |
swissspidy
reviewed
Aug 10, 2022
packages/story-editor/src/app/media/media3p/useFetchMediaEffect.js
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit, otherwise LGTM
swissspidy
changed the title
Media3P: GIFs Tab not working
Media3P: Add hardening for missing media URLs
Aug 10, 2022
…t.js Co-authored-by: Pascal Birchler <pascalb@google.com>
Plugin builds for f042260 are ready 🛎️!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Group: Media
Group: 3P Media
Third-party media provider integrations.
Type: Bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The third part media / Gif tab is failing to load -- it throws a snackbar error.
Summary
Updates
sortMediaBySize
to early return if media urls don't get passed to the parameters.In this case after filtering we can end up with an empty array
causing the eventual width / height check to fail
See: #12083 (comment)
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
Added error tracking for for fetch media
Does this PR have a legal-related impact?
no
Checklist
Type: XYZ
label to the PRFixes #12083