Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media: Fix broken video muting #12042

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Media: Fix broken video muting #12042

merged 3 commits into from
Aug 8, 2022

Conversation

swissspidy
Copy link
Collaborator

Context

It seems like video muting got broken because the new file name (of the muted version) we sent to WP did not include the extension, so WP blocks it.

We haven't changed that code in a long time, so maybe this got broken because of a change on the WP side.

Summary

This change ensures that the newly muted video file name includes the file extension.

Relevant Technical Choices

To-do

User-facing changes

No visual changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Insert a video from the library or record one
  2. Try to remove audio via the style panel
  3. Verify that removing audio works.

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12040

@googleforcreators-bot
Copy link
Collaborator

Plugin builds for 3c8881d are ready 🛎️!

@swissspidy swissspidy merged commit a28e622 into main Aug 8, 2022
@swissspidy swissspidy deleted the fix/12040-filenames branch August 8, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500 when clicking on "Remove audio"
3 participants