Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed delay before trimming a new recording #12001

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Editor: Fixed delay before trimming a new recording #12001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81278fe
Editor: Fixed delay before trimming a new recording
Jul 25, 2022
616905e
Added comment to chromium bug
Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/story-editor/src/components/videoTrim/useVideoNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ function useVideoNode(videoData) {
if (isFinite(videoNode.duration) && startOffset === null) {
onLoadedMetadata({ target: videoNode });
} else if (!isFinite(videoNode.duration)) {
// Video is a blob of unknown length, wait until it finishes
// Video is a blob of unknown length, seek to infinity and wait until it's ready
barklund marked this conversation as resolved.
Show resolved Hide resolved
// @see https://crbug.com/642012
videoNode.currentTime = Number.MAX_SAFE_INTEGER;
barklund marked this conversation as resolved.
Show resolved Hide resolved
videoNode.addEventListener('timeupdate', onLoadedMetadata);
} else {
// Video hasn't loaded yet, wait for that
Expand Down