Media: Fix empty button after cropping #11985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +104 B (0%) Total Size: 2.66 MB
ℹ️ View Unchanged
|
|
Plugin builds for 06f3212 are ready 🛎️!
|
timarney
approved these changes
Jul 27, 2022
|
In my testing this simplified approach works just as well: 06f3212 |
timarney
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Override the method to render the button toolbar, so that button name is correctly overridden.
Basically what happened here, is the override to change the name was stored in state and not in the component, when toolbar re-render, the state was empty.
Relevant Technical Choices
To-do
User-facing changes
Screen.Recording.2022-07-22.at.11.32.01.mov
Testing Instructions
This PR can be tested by following these steps:
Poster.
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #11968