Panels: fix excessive tracking events #11984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +25 B (0%) Total Size: 2.66 MB ℹ️ View Unchanged
|
|
Plugin builds for 42a0177 are ready 🛎️!
|
miina
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I noticed that there were tons of
panel_toggledtracking events being fired because thecollapseandexpandcallbacks were fired within effects.Whenever you selected an element, the events fired.
Summary
This PR fixes the excessive firing of these events by splitting up these callbacks so that the tracking events are only fired on actual user interaction.
Relevant Technical Choices
To-do
User-facing changes
n/a
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
-[x] I have added a matching
Type: XYZlabel to the PRFixes #