Editor: Multipage redesign #11934
Merged
Editor: Multipage redesign #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 18, 2022 15:19
|
Size Change: +140 B (0%) Total Size: 2.65 MB
ℹ️ View Unchanged
|
|
Plugin builds for 1915af6 are ready 🛎️!
|
miina
approved these changes
Jul 19, 2022
| @@ -32,9 +32,9 @@ export const DRAWER_BUTTON_GAP_COLLAPSED = 2; | |||
|
|
|||
| // Thumbnail size varies with available carousel size - over or under this limit | |||
| export const WIDE_CAROUSEL_LIMIT = 400; | |||
| export const WIDE_THUMBNAIL_WIDTH = 40; | |||
| export const WIDE_THUMBNAIL_HEIGHT = 60; | |||
| export const WIDE_THUMBNAIL_WIDTH = 45; | |||
There was a problem hiding this comment.
These changes would take effect regardless of the experiment being enabled, that's probably intended?
There was a problem hiding this comment.
Yeah, we want to change this regardless.
|
@swissspidy Looks like this got merged with failing Karma tests and these are now failing on |
|
Ugh, didn‘t check that. Assumed this was ready since it passed QA. Are they easy to fix? Otherwise let‘s revert |
Not sure since both tests seem to pass locally, for me at least. That doesn't make it very easy -- do these fail locally when you try? |
|
Is it the Yes it's failing for me locally 😞 Looks like the test is supposed to select both text elements but failing to do so. And because only the Title text element is selected, saving another style doesn't work because it's already been saved. Unfortunately I don't have time right now to debug this more. If nobody else can debug locally, feel free to revert or skip the test & look into it later. |
|
I'm working on it: #11983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This addresses the UX points raised in #11845.
User-facing changes
Context page proportions
Carousel page proportions
Testing Instructions
This PR can be tested by following these steps:
Checklist
Type: XYZlabel to the PRFixes #11845