Fix layer re-arrangement inside groups using shortcuts #11884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the shortcuts don't support rearranging groups currently at all, couldn't see an issue for it, should we add? cc @merapi |
|
Size Change: +409 B (0%) Total Size: 2.65 MB
ℹ️ View Unchanged
|
|
Plugin builds for 9c1f855 are ready 🛎️!
|
barklund
reviewed
Jul 7, 2022
packages/story-editor/src/app/canvas/utils/test/getLayerArrangementProps.js
Outdated
Show resolved
Hide resolved
Yeah, I think we can also add a few more things that are missing:
|
merapi
approved these changes
Jul 11, 2022
barklund
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
This works extremely well. Excellent job here - it's a much cleaner approach than we originally discussed in the ticket. You kind of merged both ideas of the navigation here - with a great result to follow!
The caveats mentioned by @merapi are significant though. Especially the one about selecting a layer from the layer panel and not being able to rearrange with keyboard directly, but having to focus the canvas element in order for key events to be registered.
Sounds good, I'll create a follow-up issue for these. |
4 tasks
Follow-up: #11906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Layer arrangement using shortcuts got broken after adding the groups feature. This PR aims to fix it.
Summary
Allows moving a layer up/down considering groups. A layer is moved inside/outside of the groups depending on the position and grouping.
If the layer is the first item of the group, and UP is pressed, the layer is moved outside of that group, the position stays the same. If the layer is the last item of the group and DOWN is pressed, the layer is moved outside of the group, the position stays the same.
The same logic is also used for moving a layer into a group.
For other cases, the logic remains as currently is.
Relevant Technical Choices
To-do
User-facing changes
Groups are now added / removed from layers when using shortcuts.
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11784