Media: Add initial Tenor stickers support #11880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Size Change: +131 B (0%) Total Size: 2.65 MB
ℹ️ View Unchanged
|
|
Plugin builds for 070f6b5 are ready 🛎️!
|
spacedmonkey
approved these changes
Jul 15, 2022
timarney
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We've added support for the sticker content type for Tenor queries in our media3p API, which means we can now include it in the editor.
Summary
Adds initial support for Tenor stickers to the 3p media library; behind a feature flag so that we can better test this.
Relevant Technical Choices
To-do
<picture>)Animated WebP images are usually larger than GIFs but also better quality, so it's a bit of a tradeoff. Need to pick one.
Related: Media: Consider using webp if available #11882
User-facing changes
After enabling the Stickers experiment, there's a new "Stickers" tab in the 3p media library:
Screen.Recording.2022-07-05.at.17.05.16.mov
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11878