-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint: Add @wordpress/i18n-no-flanking-whitespace
rule
#11868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
the
Type: Code Quality
Things that need a refactor, rewrite or just some good old developer ❤️
label
Jul 4, 2022
swissspidy
changed the title
Add @wordpress/i18n-no-flanking-whitespace linting rule.
ESLInt Add Jul 4, 2022
@wordpress/i18n-no-flanking-whitespace
rule
swissspidy
changed the title
ESLInt Add
ESLint: Add Jul 4, 2022
@wordpress/i18n-no-flanking-whitespace
rule@wordpress/i18n-no-flanking-whitespace
rule
swissspidy
changed the title
ESLint: Add
ESLint: Add Jul 4, 2022
@wordpress/i18n-no-flanking-whitespace
rule@wordpress/i18n-no-flanking-whitespace
rule
swissspidy
reviewed
Jul 4, 2022
packages/story-editor/src/components/library/panes/media/local/deleteDialog.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Jul 4, 2022
packages/story-editor/src/components/library/panes/media/local/deleteDialog.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Jul 4, 2022
swissspidy
reviewed
Jul 4, 2022
# Conflicts: # packages/story-editor/src/components/mediaRecording/provider.js
Size Change: -4 B (0%) Total Size: 2.65 MB ℹ️ View Unchanged
|
Plugin builds for c916dd7 are ready 🛎️!
|
This pull request introduces 2 alerts when merging 35e9968 into 417843a - view on LGTM.com new alerts:
|
swissspidy
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Add @wordpress/i18n-no-flanking-whitespace linting rule.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #