-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark publisher logo as such in WordPress media library #11836
Merged
swissspidy
merged 11 commits into
main
from
fix/11833-media-state-active-publisher-logo-1
Jun 29, 2022
Merged
Mark publisher logo as such in WordPress media library #11836
swissspidy
merged 11 commits into
main
from
fix/11833-media-state-active-publisher-logo-1
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timarney
changed the title
check media state for active logo
Mark publisher logo as such in WordPress media library
Jun 28, 2022
timarney
added
Group: WordPress
Changes related to WordPress or Gutenberg integration
Pod: WP
Type: Enhancement
New feature or improvement of an existing feature
labels
Jun 28, 2022
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Size Change: +2.25 kB (0%) Total Size: 2.64 MB
ℹ️ View Unchanged
|
Plugin builds for c1bbfc8 are ready 🛎️!
|
swissspidy
reviewed
Jun 29, 2022
swissspidy
approved these changes
Jun 29, 2022
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
spacedmonkey
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Group: WordPress
Changes related to WordPress or Gutenberg integration
Type: Enhancement
New feature or improvement of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add media state for Active publisher logo
See: #11833 (comment)
Summary
Adds filter to Admin.php to add the publisher logo media state
List view
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Visit the WP media library
Open the image your set as the publisher logo
Note the "Used by section" should say "Web Stories Publisher Logo"
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #11833