Editor: Fix unexpected shift of items in floating menu #11832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblinde
approved these changes
Jun 29, 2022
|
Size Change: +1 B (0%) Total Size: 2.64 MB ℹ️ View Unchanged
|
|
Plugin builds for cee9ebf are ready 🛎️!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
UI elements in the contextual floating edit menu would unexpectedly horizontally resize based on width of selected font.
Summary
These elements no longer resize.
Relevant Technical Choices
Some elements in this menu had a style rule of
width: 100%. The affected elements were in a flexbox layout, so settingwidth: 100%forced them to fill all available horizontal space, whether or not this was needed for proper styling. This style was changed towidth: autoto prevent this behavior.To-do
User-facing changes
Before - items change widths (notably the 'More' button):
https://user-images.githubusercontent.com/4173034/176249662-848bfc9e-23ca-4ee7-9d1a-c36c191d16f8.mov
After - items retain widths (note: the menu itself shows correct behavior of resizing when the color picker changes)
https://user-images.githubusercontent.com/4173034/176249969-c1fbf85a-fefe-41d3-bb10-d2575ae2d1be.mov
Testing Instructions
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11779