Dashboard: Load Spinner and Failure to load resource #11797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug/11716_Dashboard_Load_Spinner
|
Size Change: +36 B (0%) Total Size: 2.64 MB ℹ️ View Unchanged
|
|
Plugin builds for f42d93a are ready 🛎️!
|
sblinde
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix issues stories not loading on 'infinite scroll'
Summary
The Dashboards infinite scroll feature is heavily reliant on
useStoryViewto adjust thepagequery param while fetching stories. The infinite scroll increases thepagequery param and we need to reset that when filtering and sorting.Relevant Technical Choices
Adds FiltersProvider integration with the Dashboard infinite scroll functionality.
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
On Staging:
400 Failed to load resource:error in you console / network tab.On Branch:
400error, and filters should work as expected.Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11716