Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WP < 5.7 compatibility code #11790

Merged
merged 8 commits into from
Jun 27, 2022
Merged

Remove WP < 5.7 compatibility code #11790

merged 8 commits into from
Jun 27, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Jun 23, 2022 •
edited
Loading

Context

Now that 5.7 is the minimum version we need to remove code that was added for compatibility.

Summary

Updates code per #11674 (comment) as WP 5.7 will now be the minimum required version.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #11674

@timarney timarney self-assigned this Jun 23, 2022
@timarney timarney force-pushed the fix/11674-lt-5.7-cleanup branch from ee2e313 to dbcbfe5 Compare June 23, 2022 22:42
@timarney timarney added P2 Should do soon Pod: WP Type: Infrastructure Changes impacting testing infrastructure or build tooling labels Jun 24, 2022
@timarney timarney marked this pull request as ready for review June 27, 2022 09:17
@swissspidy swissspidy added the Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ label Jun 27, 2022
@swissspidy swissspidy merged commit 0ec0e8b into main Jun 27, 2022
@swissspidy swissspidy deleted the fix/11674-lt-5.7-cleanup branch June 27, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@timarney timarney

Labels
P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove WP < 5.7 compatibility code
3 participants
@timarney @spacedmonkey @swissspidy