Dashboard: Allow dashboard filters on both grid and list view #11769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.46 kB (0%) Total Size: 2.64 MB
ℹ️ View Unchanged
|
|
Plugin builds for b78c6f4 are ready 🛎️!
|
sblinde
approved these changes
Jun 22, 2022
mflorida
approved these changes
Jun 22, 2022
|
Should the issue number be at the beginning of the branch name (after feature/)? |
🤔 Im not sure if theres a standard used for branch names in this project, I believe all the branches eventually get deleted, and the actual title is how we keep track of the changes - so I dont think the branch name matters. |
spacedmonkey
approved these changes
Jun 23, 2022
|
Looks like this PR has enough approval to get merged and ready to go, but we'd like to merge #11736 in first prior to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added gird view dashboard filters to dashboard list view
Summary
Removes the exclusion of the gird view filters from the list view
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11767