POC: Editor: Multipage Canvas #11669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice -- overall :) Seeing some issues with previous and next screen previews --- likely separate from this PR as the "thumbnail" view has same issue. |
sblinde
approved these changes
Jun 17, 2022
|
Are the pages basically all just screenshots? What is the performance impact of this? Can we measure it? It might be best to put this behind a feature flag until that is more clear. |
They are all instances of
That sounds like a good idea! |
|
I'm trying to make it work on QA so the design pod can review it, right now there is no build ZIP. All good now 👍🏻 |
|
Size Change: +727 B (0%) Total Size: 2.64 MB
ℹ️ View Unchanged
|
|
Plugin builds for ab3bb64 are ready 🛎️!
|
added 3 commits
June 21, 2022 14:43
I've pushed a new version with the feature hidden by flag, just FYI. |
swissspidy
reviewed
Jun 21, 2022
Co-authored-by: Pascal Birchler <pascalb@google.com>
# Conflicts: # packages/story-editor/src/components/canvas/layout.js
…-stories-wp into try/9643-multipage
|
I can reproduce the bug from 00:13 locally and on QA. Screen.Recording.2022-06-22.at.13.58.49.movOther than that we are waiting for the design pod review (page size/margins etc). |
Whoa, that's a weird bug! I'll investigate, thanks for catching it! |
|
Approved by UX:
To do after UX review:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This adds a preview of the pages before and after the current ones to either side of the canvas, if there is enough space. It adds as many pages, as there is room for.
To-do
User-facing changes
It even works in RTL:
Testing Instructions
This PR can be tested by following these steps:
Checklist
Type: XYZlabel to the PRPartially addresses #9643