Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Add initial infrastructure #10783

Merged
merged 6 commits into from
Aug 15, 2022
Merged

TypeScript: Add initial infrastructure #10783

merged 6 commits into from
Aug 15, 2022

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Mar 2, 2022 •
edited
Loading

Context

This started as a small proof-of-concept for using TypeScript and now lays the foundation for an initial path towards a partial TypeScript adoption in this code base.

Summary

Adds the necessary tooling to support TypeScript (ESLint, Rollup, Babel, Jest, webpack, etc.).

Converts the tracking package to use TypeScript.

Relevant Technical Choices

Nothing specifically to call out

To-do

User-facing changes

N/A

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

See #1715
Fixes #12085

@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Package: Tracking /packages/tracking labels Mar 2, 2022
@swissspidy swissspidy force-pushed the try/1715-typescript branch 2 times, most recently from 4cead12 to 8284d0b Compare March 2, 2022 17:16
@swissspidy swissspidy force-pushed the try/1715-typescript branch 2 times, most recently from c54778c to 2738c29 Compare March 17, 2022 11:17
@swissspidy swissspidy force-pushed the try/1715-typescript branch 2 times, most recently from fc35b1e to 1135fa5 Compare March 29, 2022 12:07
swissspidy
swissspidy commented Apr 5, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
swissspidy
swissspidy commented Apr 5, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@swissspidy swissspidy force-pushed the try/1715-typescript branch from 1135fa5 to 5f77ce5 Compare April 13, 2022 15:05
@swissspidy swissspidy force-pushed the try/1715-typescript branch from 5f77ce5 to 5d9b30a Compare May 6, 2022 13:04
swissspidy
swissspidy commented Jun 29, 2022
View reviewed changes
rollup.config.js Outdated Show resolved Hide resolved
@swissspidy swissspidy force-pushed the try/1715-typescript branch 9 times, most recently from 3915c6c to 366955a Compare July 25, 2022 08:18
@swissspidy swissspidy force-pushed the try/1715-typescript branch from 366955a to 7209c16 Compare August 9, 2022 14:13
@swissspidy swissspidy changed the title [WIP] TypeScript proof-of-concept TypeScript: Add initial infrastructure Aug 9, 2022
@swissspidy swissspidy mentioned this pull request Aug 9, 2022
Closed
@swissspidy swissspidy force-pushed the try/1715-typescript branch from 7209c16 to ed81b5b Compare August 10, 2022 09:21
@swissspidy swissspidy marked this pull request as ready for review August 10, 2022 09:21
timarney
timarney approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@timarney timarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great to get things setup.

@swissspidy
Copy link
Collaborator Author

Forgot to add the actual type checking to the CI pipeline. Right now there are some TS errors in the tracking package 🤦

Will get those fixed

@swissspidy swissspidy marked this pull request as draft August 11, 2022 07:51
@swissspidy swissspidy marked this pull request as ready for review August 11, 2022 07:51
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 11, 2022 •
edited
Loading

Plugin builds for 7d632cf are ready 🛎️!

@swissspidy swissspidy merged commit d1a9eaa into main Aug 15, 2022
@swissspidy swissspidy deleted the try/1715-typescript branch August 15, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miina miina miina approved these changes

@timarney timarney timarney approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@barklund barklund Awaiting requested review from barklund

@merapi merapi Awaiting requested review from merapi

Assignees
No one assigned
Labels
Package: Tracking /packages/tracking Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add initial TypeScript infrastructure
4 participants
@swissspidy @googleforcreators-bot @timarney @miina