Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Incorporate all filtering state into the FiltersProvider #11789

Closed
mwritter opened this issue Jun 23, 2022 · 1 comment · Fixed by #11851
Closed

Dashboard: Incorporate all filtering state into the FiltersProvider #11789

mwritter opened this issue Jun 23, 2022 · 1 comment · Fixed by #11851
Assignees
Labels
Type: Enhancement New feature or improvement of an existing feature

Comments

@mwritter
Copy link
Contributor

mwritter commented Jun 23, 2022

Feature Description

Currently only the taxonomy filters and the author filter utilize the FiltersProvider. Any state that can update which stories are shown (ie Taxonomy filters, Author filter, Sort, Status Filter, Keyword search) should utilize the FiltersProvider.

Currently we are handling 'filtering' in multiple different places FiltersProvider, mystories/index, and useStoryView. This makes it hard to debug issues on the dashboard and to update filtering logic on the dashboard. Moving all filtering logic into one place will remove complexity in this area and should increase DX while working on the dashboard.

As part of this work, we should expect that #11668 should be resolved as a test case to get this consolidated.

Alternatives Considered

Let the filtering logic be in multiple places. This would lead to ambiguity on how to add / update the logic surrounding dashboard filters and the complexity in this area will continue to rise.

Additional Context

Filters Improvement

@mwritter mwritter added Type: Enhancement New feature or improvement of an existing feature Pod: Pea labels Jun 23, 2022
@sblinde sblinde removed their assignment Jun 23, 2022
@sblinde
Copy link
Contributor

sblinde commented Jun 23, 2022

This ticket should also take care of the issue seen in #11668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants