Dashboard: Status filter + author filter not working well together

[spacedmonkey]

Bug Description

If you have a story status filter set and then you filter by author, if that author does not have a anything in that status, then story status should reset to all or something.

See video.

Expected Behaviour

Steps to Reproduce

1. Open dashboard.
2. Filter by pending.
3. Filter by author ( author must not have pending story ).
4. See status filter not highlighted.

Screenshots

Screen.Recording.2022-06-10.at.11.37.09.mov

Additional Context

• Plugin Version: 1.22.0
• WordPress Version: 6.0
• Operating System:
• Browser:

[sblinde]

Great find! We added this to the epic for filtering improvements / enhancements.

[sblinde]

Linking this reported issue to #11789, and removing estimate as this will be an incident report that should be resolved with that greater work.

[mwritter]

@spacedmonkey @swissspidy @sblinde - Im currently addressing this issue in #11789 and Im working on implementing a solution but wanted to get some feedback on how to handle this issue.

if that author does not have anything in that status, then story status should reset to all or something.

🤔 The 'status filter' updates every time the user changes any other filter, so once the other filter updates we make a call to the backend for the stories, which gives us the 'status counts' for the given set of filters. So once we found that there are no stories for the given set of filters we would have to make a second call to the backend to 'reset' the status filter. Im not sure if we want to do that. Any insight on a better way to 'reset' would be greatly appreciated if we do wanna go down that path.

I do have a working solution that gives a better visual cue to the user though to let them know they're filtering by a status that has no results, any feedback on this implementation or suggestion would be great.

Screen.Recording.2022-06-28.at.11.17.34.AM.mov

[swissspidy]

What you demo in the video seems fine to me. I wouldn't further complicate it though by doing multiple requests or anything.

[sblinde]

Agreed w/ @swissspidy as well!