-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Add Semantic Headings to the right click menu of Text Elements #11402
Comments
Implementation note: this would mean exporting While this needs UX, we can already implement something behind a feature flag. Suggestion:
When changing this option, the text element's
Below the dropdown we can add a helper text Mock: Context: |
Andrew to provide UX guidance on this one |
Our plan is to include this in the upcoming release, so this story will be pulled in to the sprint once we have UX (which I hope to talk about on Tuesday!) |
As talked about in our design sync meeting, we can approach this as suggested by @swissspidy and also consider adding this to the right click menu dropdown as a submenu item to be changed. Will follow back up with this ticket to get those requests written out appropriately with context. |
For additional context on how this was accomplished for the Editor sidebar, see: #11788 |
Issue found. Tested against https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin/, using PR #12062.
|
@felipebochehin87 the code is updated to fix #11402 (comment) |
Looks good. Thanks! |
1 similar comment
Looks good. Thanks! |
Feature Description
Now that automatic semantic headings are applied to text elements within stories (see #5326), users are requesting a way to be able to view what that value is or will be on publish so adjustments can be made beforehand.
This feature will allow a user to select the text within a page and see and change the text element within the sidebar.
Many thanks to @swissspidy for the implementation idea, and to @aaskedall for the UX guidance.
Acceptance Criteria
feature/11788-experiment-semantic-headings
... Please branch off of this when working on this feature.Automatic (xyz)
(stored asauto
)Heading 1
(stored ash1
)Heading 2
(stored ash2
)Heading 3
(stored ash3
)Paragraph
(stored asp
)tagName property
Developer Notes
Notes from @swissspidy on implementation:
xyz
is replaced with whatevergetTextElementTagNames()
returns for the element.When changing this option, the text element's
tagName
property is updated.getTextElementTagNames()
is updated to take thistagName
property into account.Alternatives Considered
In addition to this space, this functionality will also be accomplished within the sidebar of the Editor.
Additional Context
The text was updated successfully, but these errors were encountered: