Print kubectl client version #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
reviewed
Sep 18, 2018
pkg/skaffold/deploy/kubectl.go
Outdated
| @@ -64,6 +64,8 @@ func (k *KubectlDeployer) Labels() map[string]string { | |||
| // Deploy templates the provided manifests with a simple `find and replace` and | |||
| // runs `kubectl apply` on those manifests | |||
| func (k *KubectlDeployer) Deploy(ctx context.Context, out io.Writer, builds []build.Artifact) ([]Artifact, error) { | |||
| logrus.Debugln("kubectl client version:", k.kubectl.Version()) | |||
There was a problem hiding this comment.
nit: I would even consider making this Info level log
9d6da67 to
ab1ee87
Compare
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 40.17% 39.92% -0.26%
==========================================
Files 68 69 +1
Lines 3004 3026 +22
==========================================
+ Hits 1207 1208 +1
- Misses 1671 1692 +21
Partials 126 126
Continue to review full report at Codecov.
|
|
@nkubala It should be all good now. |
dlorenc
approved these changes
Sep 21, 2018
|
|
||
| buf, err := c.getVersion(context.Background()) | ||
| if err != nil { | ||
| logrus.Errorln("unable to get kubectl client version", err) |
There was a problem hiding this comment.
Should this be a warning instead of an error since it's not really fatal?
Signed-off-by: David Gageot <david@gageot.net>
ab1ee87 to
3158437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net