-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: final cleanups of the go.mod file #9663
chore: final cleanups of the go.mod file #9663
Conversation
plumpy
commented
Jan 14, 2025
•
edited
Loading
edited
- Two deps moved, pin the old paths at the last version from that path
- this was suggested by the mergo readme
- update the Skaffold import to use the new path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @plumpy, @reviewers,
I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary of the changes for you and other reviewers to get up to speed:
This pull request, "chore: final cleanups of the go.mod file", aims to perform some final cleanups on the go.mod
file. The changes include:
- Removing an outdated exclude: The line
exclude github.com/karrick/godirwalk v1.17.0
has been removed fromgo.mod
. - Moving and pinning dependencies: Two dependencies have been moved to new paths. The old paths are pinned to their last known versions:
github.com/alessio/shellescape
is replaced withgithub.com/alessio/shellescape v1.4.2
github.com/imdario/mergo
is replaced withgithub.com/imdario/mergo v0.3.16
- Updating other dependencies: Several other dependencies have been updated to their latest versions. This includes updates to
github.com/aws/aws-sdk-go-v2/config
,github.com/aws/aws-sdk-go-v2/credentials
,github.com/aws/aws-sdk-go-v2/service/ecr
, andgithub.com/aws/aws-sdk-go-v2/service/sts
, among others. The specific version changes are detailed in the diffs forgo.mod
andgo.sum
. - Updating import path: The import path for the
mergo
library inpkg/skaffold/config/util.go
has been updated fromgithub.com/imdario/mergo
todario.cat/mergo
(line 30). - Improvements to
godirwalk
documentation and error handling: The documentation for thegodirwalk
library has been improved to include instructions on preventing resource leaks (lines 26-29, 58-63, 81-83, 118-121 ofscandir_unix.go
and lines 21-24, 58-67, 72-74, 109-112 ofscandir_windows.go
). Error handling has also been improved inscandir_unix.go
(lines 102-111, 150-156) andscandir_windows.go
(lines 96-107).
The changes to go.sum
reflect the updated dependency versions. The modules.txt
file also shows the changes made to the dependencies.
I've reviewed the changes and they appear to be well-structured and thoroughly documented. I'll provide a more detailed review shortly.
And now, a little haiku to lighten the mood:
Go modules clean,
Dependencies aligned now,
Code flows smoothly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR cleans up the go.mod
file by removing an outdated exclude directive and pinning dependencies that have changed paths. This is good practice for dependency management and ensures reproducible builds. The changes are well-justified and follow the recommendations from the mergo
readme.
a05aad3
to
65cbaab
Compare