feat(verify.go): Add pod fail reason and message to output #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanperkins
approved these changes
Nov 28, 2024
louisjimenez
approved these changes
Dec 9, 2024
|
@idsulik Can you pull HEAD into this PR, I believe that will address the failing checks. This commit should help https://github.com/GoogleContainerTools/skaffold/pull/9604/commits |
|
@louisjimenez thank you, rebased main |
|
@idsulik We recently merged some changes to fix dependency issues. Are you able to rebase this one more time? My apologies for the inconvenience. |
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
|
@louisjimenez rebased this PR and this #9624 |
alphanota
pushed a commit
to alphanota/skaffold
that referenced
this pull request
Jan 14, 2025
…tainerTools#9589) * feat(verify.go): Add pod fail reason and message to output Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * fix verify.go Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> --------- Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9587
Description
Add pod fail details Into the
watchJobmethod of the verifierUser facing changes
before: no details -
%q running job %q errored during runafter: fail details -
%q running job %q errored during run: reason=%q, message=%q