Pull 'cache-from' images on Google Cloud Build #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GoogleContainerTools#936 Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
==========================================
+ Coverage 43.78% 43.93% +0.14%
==========================================
Files 63 64 +1
Lines 2654 2661 +7
==========================================
+ Hits 1162 1169 +7
Misses 1370 1370
Partials 122 122
Continue to review full report at Codecov.
|
dlorenc
reviewed
Sep 7, 2018
| desc := builder.buildDescription(artifact, "bucket", "object") | ||
|
|
||
| expected := []*cloudbuild.BuildStep{{ | ||
| Name: "docker/docker", |
There was a problem hiding this comment.
This is unrelated to your change, but should we be using https://github.com/GoogleCloudPlatform/cloud-builders/tree/master/docker instead of docker/docker as the image?
There was a problem hiding this comment.
By default, we do. This is just a test
dlorenc
approved these changes
Sep 7, 2018
| desc := builder.buildDescription(artifact, "bucket", "object") | ||
|
|
||
| expected := []*cloudbuild.BuildStep{{ | ||
| Name: "docker/docker", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936
Signed-off-by: David Gageot david@gageot.net