Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TestGenerateMavenBuildArgs-host-platform #9410

Merged
merged 2 commits into from
May 3, 2024
Merged

fix: TestGenerateMavenBuildArgs-host-platform #9410

merged 2 commits into from
May 3, 2024

Conversation

ericzzzzzzz
Copy link
Contributor

  • This pr fixes TestGenerateMavenBuildArgs_host_platform, this test was failing due to github ci started using arm machine. So the defaultPlatformSpec contains Variant -- "v8" in the ci run, the test now uses platform.Format method to format defaultPlatformSpec instead of 'runtime.OS/runtime.platform', so when we run tests in an arm machine, platform.Format method will give us "OS/Arch/Variant"

@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner May 3, 2024 13:42
@ericzzzzzzz ericzzzzzzz requested a review from maggieneterval May 3, 2024 13:42
@ericzzzzzzz ericzzzzzzz requested a review from renzodavid9 May 3, 2024 14:13
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 3, 2024
@ericzzzzzzz ericzzzzzzz merged commit b4dd93f into GoogleContainerTools:main May 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzodavid9 renzodavid9 renzodavid9 approved these changes

@maggieneterval maggieneterval Awaiting requested review from maggieneterval maggieneterval is a code owner automatically assigned from GoogleContainerTools/skaffold-team

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericzzzzzzz @renzodavid9 @kokoro-team