-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent watcher failure if helm valuesFilePath not set #930
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it! (for my corp email) |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 40.17% 40.17%
=======================================
Files 68 68
Lines 3004 3004
=======================================
Hits 1207 1207
Misses 1671 1671
Partials 126 126 Continue to review full report at Codecov.
|
@rsanders I'm sorry you have to rebase |
@rsanders for that PR to be merged, I'm afraid it has to be rebased. |
The config file version changed, and I'm not sure this is even still necessary. It would only be necessary for people using the alpha2 format in any case. In any case, the patch is up to date now. |
@rsanders thanks for the fix! |
If the Helm deployment section's valuesFilePath is not set, the helm deployer in dev mode will fail due to the watcher observing a non-existent blank filename.
Example pipeline file: