Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent watcher failure if helm valuesFilePath not set #930

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

rsanders
Copy link
Contributor

If the Helm deployment section's valuesFilePath is not set, the helm deployer in dev mode will fail due to the watcher observing a non-existent blank filename.

$ skaffold dev                                                          
Cleaning up...
Error: release: "unified-k8s-repo" not found
Cleanup complete in 1.251887709s
FATA[0001] watching files for deployer: listing files: unable to stat file : stat : no such file or directory

Example pipeline file:

apiVersion: skaffold/v1alpha2
kind: Config
build:
  tagPolicy:
    # Tag the image with the git commit of your current repository.
    gitCommit: {}

  artifacts:
  - imageName: my-registry.com/rsanders/unified-k8s-repo
    docker:
      # Dockerfile's location relative to workspace. Defaults to "Dockerfile"
      dockerfilePath: docker/Dockerfile

deploy:
  helm:
    releases:
    - name: unified-k8s-repo
      chartPath: deploy/helm/unified-k8s-repo
      wait: true
      #valuesFilePath: helm-skaffold-values.yaml
      values:
        image: my-registry.com/rsanders/unified-k8s-repo

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@rsanders
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@rsanders
Copy link
Contributor Author

I signed it! (for my corp email)

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #930 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   40.17%   40.17%           
=======================================
  Files          68       68           
  Lines        3004     3004           
=======================================
  Hits         1207     1207           
  Misses       1671     1671           
  Partials      126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8eec1b...edcea0c. Read the comment docs.

@dgageot
Copy link
Contributor

dgageot commented Sep 7, 2018

@rsanders I'm sorry you have to rebase

@dgageot
Copy link
Contributor

dgageot commented Sep 21, 2018

@rsanders for that PR to be merged, I'm afraid it has to be rebased.

@rsanders rsanders reopened this Sep 21, 2018
@rsanders rsanders requested a review from nkubala as a code owner September 21, 2018 12:33
@rsanders
Copy link
Contributor Author

The config file version changed, and I'm not sure this is even still necessary. It would only be necessary for people using the alpha2 format in any case. In any case, the patch is up to date now.

@nkubala
Copy link
Contributor

nkubala commented Sep 24, 2018

@rsanders thanks for the fix!

@nkubala nkubala merged commit 82f5dc0 into GoogleContainerTools:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants