Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs #918

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Improve logs #918

merged 2 commits into from
Aug 24, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 22, 2018

  • Simplify the code: we don't need to reconnect the watch if we give a proper timeout.
  • Fix a bug where we could miss a few logs. Add a few tests and comments.

@dgageot dgageot requested review from balopat and r2d4 as code owners August 22, 2018 16:23
@dgageot
Copy link
Contributor Author

dgageot commented Aug 22, 2018

ping @bobcatfish This comes from the discussion we've had on the code that prints the logs.

@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #918 into master will increase coverage by 0.19%.
The diff coverage is 15.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   41.71%   41.91%   +0.19%     
==========================================
  Files          61       61              
  Lines        2522     2522              
==========================================
+ Hits         1052     1057       +5     
+ Misses       1356     1351       -5     
  Partials      114      114
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 4.09% <15.62%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a04db...984a0ef. Read the comment docs.

Signed-off-by: David Gageot <david@gageot.net>
Fix the code and add a few tests and comments.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 6ad057a into GoogleContainerTools:master Aug 24, 2018
@dgageot dgageot deleted the improve-logs branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants