Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: doc page for Custom Actions and skaffold exec #8809

Merged
merged 2 commits into from
May 24, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented May 23, 2023

Fixes: #8523

Description
This PR adds the new documentation page for Custom Actions + the needed examples.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #8809 (470ba8f) into main (290280e) will decrease coverage by 6.55%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8809      +/-   ##
==========================================
- Coverage   70.48%   63.94%   -6.55%     
==========================================
  Files         515      620     +105     
  Lines       23150    31455    +8305     
==========================================
+ Hits        16317    20113    +3796     
- Misses       5776     9837    +4061     
- Partials     1057     1505     +448     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 410 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review May 23, 2023 19:02
@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 23, 2023
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-8809, please visit https://storage.googleapis.com/webhook-logs/logs-8809-1684868732994571668 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 23, 2023
@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 24, 2023
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-8809, please visit https://storage.googleapis.com/webhook-logs/logs-8809-1684951843832885133 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 24, 2023
@renzodavid9 renzodavid9 added the docs-modifications runs the docs preview service on the given PR label May 24, 2023
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-8809, please visit https://storage.googleapis.com/webhook-logs/logs-8809-1684952516859669471 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label May 24, 2023
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 44a5904 into GoogleContainerTools:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Actions] Create documentation page
3 participants