Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add script to update lts dependencies #8773

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented May 11, 2023

Fixes #7922

Adds a script that automatically - fetches latest version of deps, uploads necessary files to GCS, and updates related Dockerfiles. Method used to get latest deps is flaky and should be double checked.

aprindle@aprindle-ssd ~/skaffold  [update-lts-dependencies-sh]hack/update-lts-dependencies.sh 
Updating kubectl to version: v1.27.1
Updating helm to version: v3.12.0
Updating kustomize to version: 5.0.3
Updating kpt to version: 1.0.0-beta.32
Updating gcloud to version: 430.0.0

WARNING: the method used to get deps comes from combination of Github latest release and latest git tag on a repo. These methods of getting the latest version of a binary are not error prone and should be manually checked.  For gcloud there is no api endpoint to check for the latest version so the output of 'gcloud version' is used asssuming the machine running this command has the latest gcloud version.  Manual modification of the script is required in cases where the version found by the script is incorrect.

@aaron-prindle aaron-prindle marked this pull request as ready for review May 11, 2023 22:56
@aaron-prindle aaron-prindle force-pushed the update-lts-dependencies-sh branch 3 times, most recently from b482f71 to 8c9cd53 Compare May 11, 2023 23:08
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #8773 (ef9b1c5) into main (290280e) will decrease coverage by 6.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8773      +/-   ##
==========================================
- Coverage   70.48%   64.41%   -6.07%     
==========================================
  Files         515      617     +102     
  Lines       23150    31171    +8021     
==========================================
+ Hits        16317    20080    +3763     
- Misses       5776     9588    +3812     
- Partials     1057     1503     +446     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 406 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle force-pushed the update-lts-dependencies-sh branch 6 times, most recently from 0f53054 to dc7fb51 Compare May 11, 2023 23:20
@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label May 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 12, 2023
@aaron-prindle aaron-prindle force-pushed the update-lts-dependencies-sh branch from dc7fb51 to ef9b1c5 Compare May 15, 2023 02:49
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 15, 2023
@aaron-prindle aaron-prindle added the kokoro:force-run forces a kokoro re-run on a PR label May 15, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 15, 2023
@aaron-prindle aaron-prindle added this to the v2.6.0 milestone May 16, 2023
@aaron-prindle aaron-prindle merged commit 3d6bc72 into GoogleContainerTools:main May 16, 2023
@aaron-prindle aaron-prindle modified the milestones: v2.6.0, v2.5.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a script to mirror skaffold dependant binaries that images depend on
3 participants