Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix transformer share config-map issues #8582

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Mar 24, 2023

Fixes: #8580
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • kpt Transformers with the same name are currently sharing configmap which can produce unexpected behavior
    • uses could define create-setter, apply-setter, create-setter, apply-setter in a row in skaffold transform stanza
      each entry should only be able to access its own datamap
  • kpt set-namespace image doesn't have a latest version, we need to specify the version, so added one.
  • change cmd run to use util cmd run to make debugging life easier

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #8582 (6dff73d) into main (290280e) will decrease coverage by 6.24%.
The diff coverage is 54.18%.

@@            Coverage Diff             @@
##             main    #8582      +/-   ##
==========================================
- Coverage   70.48%   64.24%   -6.24%     
==========================================
  Files         515      610      +95     
  Lines       23150    30580    +7430     
==========================================
+ Hits        16317    19647    +3330     
- Misses       5776     9461    +3685     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/diagnose.go 62.22% <0.00%> (-2.65%) ⬇️
cmd/skaffold/app/cmd/flags.go 93.00% <ø> (+2.18%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
... and 38 more

... and 388 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review March 24, 2023 16:24
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Mar 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 24, 2023
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit f3f305a into GoogleContainerTools:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting namespace when using manifests.transform fails with exit status 1
3 participants