Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change verify schema from v1.Container to subset of direct primitive types #8577

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

aaron-prindle
Copy link
Contributor

fixes #8576

@aaron-prindle aaron-prindle force-pushed the fix-8576 branch 2 times, most recently from 5acf577 to 0a97b44 Compare March 24, 2023 05:29
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #8577 (7173ac8) into main (290280e) will decrease coverage by 6.28%.
The diff coverage is 54.32%.

@@            Coverage Diff             @@
##             main    #8577      +/-   ##
==========================================
- Coverage   70.48%   64.20%   -6.28%     
==========================================
  Files         515      610      +95     
  Lines       23150    30594    +7444     
==========================================
+ Hits        16317    19643    +3326     
- Misses       5776     9479    +3703     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 38 more

... and 389 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle added kokoro:force-run forces a kokoro re-run on a PR and removed kokoro:force-run forces a kokoro re-run on a PR labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve skaffold verify schema s.t. it no longer users v1.Container
2 participants