Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retag multiarch images #8493

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

gsquared94
Copy link
Contributor

Fixes: #8380

Description

Fixes issue with remote tagging not selecting the correct platforms.

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #8493 (82aa523) into main (290280e) will decrease coverage by 5.29%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8493      +/-   ##
==========================================
- Coverage   70.48%   65.20%   -5.29%     
==========================================
  Files         515      602      +87     
  Lines       23150    29911    +6761     
==========================================
+ Hits        16317    19503    +3186     
- Misses       5776     8937    +3161     
- Partials     1057     1471     +414     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using --tag re-tags linux/amd64 image on multi-platform builds
2 participants