Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Whitelist strimzi.io CRDs #8491

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

deedubs
Copy link
Contributor

@deedubs deedubs commented Mar 3, 2023

Allow replacing images in strimzi.io CRD files

Allow replacing images in strimzi.io CRD files
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #8491 (53233c7) into main (290280e) will decrease coverage by 5.29%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8491      +/-   ##
==========================================
- Coverage   70.48%   65.19%   -5.29%     
==========================================
  Files         515      602      +87     
  Lines       23150    29912    +6762     
==========================================
+ Hits        16317    19501    +3184     
- Misses       5776     8939    +3163     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deedubs
Copy link
Contributor Author

deedubs commented Mar 3, 2023

Test failure looks like a timeout in an unrelated test

@aaron-prindle
Copy link
Contributor

Re-triggered the test, passing now\

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR here @deedubs. LGTM!

@aaron-prindle aaron-prindle merged commit fd6a654 into GoogleContainerTools:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants