Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Security hotfixes for v2.0.6 branch #8480

Merged

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Mar 1, 2023

Changes here cherry-pick the following security related fixes on-top of the v2.0.5 branch:

* chore: Revert "chore: change skaffold base image (GoogleContainerTools#8433)"

This reverts commit 6b3f673.

* chore: update skaffold base image to ubuntu:20.04

* chore: add noninteractive

(cherry picked from commit 9847653)
@aaron-prindle aaron-prindle changed the title Security hotfixes for v2.0.6 branch chore: Security hotfixes for v2.0.6 branch Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.0.6@a3efe9d). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release/v2.0.6    #8480   +/-   ##
=================================================
  Coverage                  ?   66.29%           
=================================================
  Files                     ?      597           
  Lines                     ?    29276           
  Branches                  ?        0           
=================================================
  Hits                      ?    19408           
  Misses                    ?     8411           
  Partials                  ?     1457           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle
Copy link
Contributor Author

Linux issue not related to changes here. The error:

    panic.go:522: parsing skaffold config: error parsing skaffold configuration file: unknown skaffold config API version "skaffold/v4beta2". Set the config 'apiVersion' to a known value. Check https://skaffold.dev/docs/references/yaml/ for the list of valid API versions. Otherwise, check that your skaffold version is up-to-date.

is referring to the fact that between the v2.0.0 release and the v2.0.5 release there were schema upgrades (v4beta1 -> v4beta2) but our tooling was not properly updated each time. There should not be any issue here (see the commits added)

@aaron-prindle aaron-prindle merged commit 29e4c2f into GoogleContainerTools:release/v2.0.6 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants