Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand home directory for docker secrets #8476

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

griseau
Copy link
Contributor

@griseau griseau commented Feb 24, 2023

Fixes: #8453
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

As mentioned in the issue, when using ~/ for secret path, this wasn't expended to home directory but was happened after current directory. This change expends the path to the realpath of home directory if starting with ~/

User facing changes (remove if N/A)

No user facing changes other than have it working as intended

Follow-up Work (remove if N/A)

Should we test the util function ? It's only calling Go standard package

And thanks @smaftoul for your help on this one ;)

@google-cla
Copy link

google-cla bot commented Feb 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #8476 (937802c) into main (290280e) will decrease coverage by 5.27%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8476      +/-   ##
==========================================
- Coverage   70.48%   65.22%   -5.27%     
==========================================
  Files         515      602      +87     
  Lines       23150    29889    +6739     
==========================================
+ Hits        16317    19494    +3177     
- Misses       5776     8922    +3146     
- Partials     1057     1473     +416     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Feb 24, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 24, 2023
@griseau
Copy link
Contributor Author

griseau commented Feb 24, 2023

@ericzzzzzzz I see the issue with the test failing but not sure to understand, any help for resolving this ?

@ericzzzzzzz
Copy link
Contributor

@griseau This seems like a flaky test.. just re-ran to see if the test pass.

@ericzzzzzzz ericzzzzzzz merged commit e53a940 into GoogleContainerTools:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to reference secrets path to home folder
3 participants