chore: add test

examples/getting-started-kustomize/base/deployment.yaml

@@ -4,7 +4,6 @@ metadata:
   name: skaffold-kustomize
   labels:
     app: skaffold-kustomize # kpt-set: ${app1}
-  namespace: default # kpt-set: ${nameb}
 spec:
   selector:
     matchLabels:

examples/getting-started-kustomize/overlays/dev/deployment.yaml

@@ -3,5 +3,4 @@ kind: Deployment
 metadata:
   name: skaffold-kustomize
   labels:
-    env: dev
-  namespace: hello-no # kpt-set: ${nameb}
+    env: dev # kpt-set: ${env2}

examples/getting-started-kustomize/overlays/staging/deployment.yaml

@@ -3,4 +3,4 @@ kind: Deployment
 metadata:
   name: skaffold-kustomize
   labels:
-    env: staging # kpt-set: ${app2}
+    env: staging

examples/kustomize/skaffold.yaml

@@ -7,10 +7,4 @@ manifests:
   transform:
     - name: set-annotations
       configMap:
-        - "author:fake-author"
-  #    - name: create-setters
-  #      configMap:
-  #        - "app:guestbook"
-  #    - name: apply-setters
-  #      configMap:
-  #        - "app:guestbook-fake-author"
+        - "author:fake-author"

integration/render_test.go

@@ -390,6 +390,34 @@ spec:
       containers:
       - image: skaffold-helm:latest
         name: skaffold-helm
+`,
+		}, {
+			description:      "Template replicaCount with --set flag",
+			dir:              "testdata/helm-render-simple",
+			args:             []string{"--set", "replicaCount=3"},
+			withoutBuildJSON: true,
+			expectedOut: `apiVersion: apps/v1
+kind: Deployment
+metadata:
+  labels:
+    app: skaffold-helm
+    skaffold.dev/run-id: phony-run-id
+  name: skaffold-helm
+  namespace: helm-namespace
+spec:
+  replicas: 3
+  selector:
+    matchLabels:
+      app: skaffold-helm
+  template:
+    metadata:
+      labels:
+        app: skaffold-helm
+        skaffold.dev/run-id: phony-run-id
+    spec:
+      containers:
+      - image: skaffold-helm:latest
+        name: skaffold-helm
 `,
 		},
 	}
@@ -873,6 +901,269 @@ spec:
 	}
 }
 
+func TestRenderWithTransformer(t *testing.T) {
+	tests := []struct {
+		description string
+		args        []string
+		config      string
+		input       map[string]string // file path => content
+		expectedOut string
+	}{
+		{
+			description: "kubectl set manifest label with apply-setters",
+			args:        []string{"--offline=true"},
+			config: `apiVersion: skaffold/v4beta2
+		kind: Config
+		manifests:
+		 rawYaml:
+		 - k8s-pod.yaml
+		 transform:
+		   - name: apply-setters
+		     configMap:
+		       - "app1:from-apply-setters-1"
+		`,
+			input: map[string]string{
+				"k8s-pod.yaml": `apiVersion: v1
+		kind: Pod
+		metadata:
+		 name: getting-started
+		 labels:
+		   a: hhhh # kpt-set: ${app1}
+		spec:
+		 containers:
+		 - name: getting-started
+		   image: skaffold-example`,
+			}, expectedOut: `apiVersion: v1
+		kind: Pod
+		metadata:
+		 name: getting-started
+		 labels:
+		   a: from-apply-setters-1
+		spec:
+		 containers:
+		 - name: getting-started
+		   image: skaffold-example
+		`,
+		},
+		{
+			description: "kubectl set manifest label with --set flag overrides transform in manifest",
+			args:        []string{"--offline=true", "--set", "app1=from-command-line"},
+			config: `apiVersion: skaffold/v4beta2
+		kind: Config
+		manifests:
+		 rawYaml:
+		 - k8s-pod.yaml
+		 transform:
+		   - name: apply-setters
+		     configMap:
+		       - "app1:from-apply-setters-1"
+		`,
+			input: map[string]string{
+				"k8s-pod.yaml": `apiVersion: v1
+		kind: Pod
+		metadata:
+		 name: getting-started
+		 labels:
+		   a: hhhh # kpt-set: ${app1}
+		spec:
+		 containers:
+		 - name: getting-started
+		   image: skaffold-example`,
+			}, expectedOut: `apiVersion: v1
+		kind: Pod
+		metadata:
+		 name: getting-started
+		 labels:
+		   a: from-command-line
+		spec:
+		 containers:
+		 - name: getting-started
+		   image: skaffold-example
+		`,
+		},
+		{description: "kustomize set annotation with set-annotations transformer",
+			args: []string{"--offline=true"},
+			config: `apiVersion: skaffold/v4beta2
+		kind: Config
+		manifests:
+		 kustomize:
+		   paths:
+		     - .
+		 transform:
+		   - name: set-annotations
+		     configMap:
+		       - "author:fake-author"`,
+			input: map[string]string{"kustomization.yaml": `resources:
+		 - deployment.yaml
+		patchesStrategicMerge:
+		 - patch.yaml
+		`, "deployment.yaml": `apiVersion: apps/v1
+		kind: Deployment
+		metadata:
+		 name: kustomize-test
+		 labels:
+		   app: kustomize-test
+		spec:
+		 replicas: 1
+		 selector:
+		   matchLabels:
+		     app: kustomize-test
+		 template:
+		   metadata:
+		     labels:
+		       app: kustomize-test
+		   spec:
+		     containers:
+		     - name: kustomize-test
+		       image: not/a/valid/image
+		`, "patch.yaml": `apiVersion: apps/v1
+		kind: Deployment
+		metadata:
+		 name: kustomize-test
+		spec:
+		 template:
+		   spec:
+		     containers:
+		     - name: kustomize-test
+		       image: index.docker.io/library/busybox
+		       command:
+		         - sleep
+		         - "3600"
+		`},
+			expectedOut: `apiVersion: apps/v1
+		kind: Deployment
+		metadata:
+		 annotations:
+		   author: fake-author
+		 labels:
+		   app: kustomize-test
+		 name: kustomize-test
+		spec:
+		 replicas: 1
+		 selector:
+		   matchLabels:
+		     app: kustomize-test
+		 template:
+		   metadata:
+		     annotations:
+		       author: fake-author
+		     labels:
+		       app: kustomize-test
+		   spec:
+		     containers:
+		     - command:
+		       - sleep
+		       - "3600"
+		       image: index.docker.io/library/busybox
+		       name: kustomize-test
+		`},
+		{
+			description: "kustomize/overlay parameterization with --set flag",
+			args:        []string{"--offline", "--set", "env2=222", "--set", "app1=111"},
+			config: `apiVersion: skaffold/v4beta2
+kind: Config
+metadata:
+  name: getting-started-kustomize
+manifests:
+  kustomize:
+    paths:
+    - overlays/dev
+`, input: map[string]string{
+				"base/kustomization.yaml": `apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+resources:
+  - deployment.yaml
+`, "base/deployment.yaml": `apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: skaffold-kustomize
+  labels:
+    app: skaffold-kustomize # kpt-set: ${app1}
+spec:
+  selector:
+    matchLabels:
+      app: skaffold-kustomize
+  template:
+    metadata:
+      labels:
+        app: skaffold-kustomize
+    spec:
+      containers:
+      - name: skaffold-kustomize
+        image: skaffold-kustomize
+`, "overlays/dev/kustomization.yaml": `apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+# namespace: dev
+nameSuffix: -dev
+
+patchesStrategicMerge:
+- deployment.yaml
+
+resources:
+- ../../base
+`, "overlays/dev/deployment.yaml": `apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: skaffold-kustomize
+  labels:
+    env: dev # kpt-set: ${env2}
+`}, expectedOut: `
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  labels:
+    app: 111
+    env: "222"
+  name: skaffold-kustomize-dev
+spec:
+  selector:
+    matchLabels:
+      app: skaffold-kustomize
+  template:
+    metadata:
+      labels:
+        app: skaffold-kustomize
+    spec:
+      containers:
+      - image: skaffold-kustomize
+        name: skaffold-kustomize
+`,
+		},
+	}
+
+	for _, test := range tests {
+		testutil.Run(t, test.description, func(t *testutil.T) {
+			MarkIntegrationTest(t.T, CanRunWithoutGcp)
+			tmpDir := t.NewTempDir()
+			tmpDir.Write("skaffold.yaml", test.config)
+
+			for filePath, content := range test.input {
+				fmt.Println(filePath)
+
+				tmpDir.Write(filePath, content)
+			}
+
+			tmpDir.Chdir()
+			output := skaffold.Render(test.args...).RunOrFailOutput(t.T)
+			var out map[string]any
+			var ex map[string]any
+			err := yaml.Unmarshal(output, &out)
+			if err != nil {
+				return
+			}
+			err = yaml.Unmarshal([]byte(test.expectedOut), &ex)
+			if err != nil {
+				return
+			}
+
+			t.CheckDeepEqual(ex, out)
+		})
+	}
+
+}
+
 func TestRenderWithTagFlag(t *testing.T) {
 	MarkIntegrationTest(t, CanRunWithoutGcp)
 

integration/testdata/helm-render-simple/charts/Chart.yaml

@@ -0,0 +1,4 @@
+apiVersion: v1
+description: Skaffold example with Helm
+name: skaffold-helm
+version: 0.1.0

integration/testdata/helm-render-simple/charts/templates/deployment.yaml

@@ -0,0 +1,20 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: {{ .Chart.Name }}
+  namespace: {{ .Release.Namespace }}
+  labels:
+    app: {{ .Chart.Name }}
+spec:
+  selector:
+    matchLabels:
+      app: {{ .Chart.Name }}
+  replicas: {{ .Values.replicaCount }}
+  template:
+    metadata:
+      labels:
+        app: {{ .Chart.Name }}
+    spec:
+      containers:
+      - name: {{ .Chart.Name }}
+        image: {{ .Values.image }}

integration/testdata/helm-render-simple/charts/values.yaml

@@ -0,0 +1,5 @@
+# Default values for skaffold-helm.
+# This is a YAML-formatted file.
+# Declare variables to be passed into your templates.
+replicaCount: 2
+image: skaffold-helm:latest

integration/testdata/helm-render-simple/skaffold.yaml

@@ -0,0 +1,8 @@
+apiVersion: skaffold/v4beta2
+kind: Config
+manifests:
+  helm:
+    releases:
+      - name: skaffold-helm
+        chartPath: charts
+        namespace: helm-namespace

integration/testdata/transform/kubectl/Dockerfile

@@ -0,0 +1,14 @@
+FROM golang:1.18 as builder
+WORKDIR /code
+COPY main.go .
+COPY go.mod .
+# `skaffold debug` sets SKAFFOLD_GO_GCFLAGS to disable compiler optimizations
+ARG SKAFFOLD_GO_GCFLAGS
+RUN go build -gcflags="${SKAFFOLD_GO_GCFLAGS}" -trimpath -o /app main.go
+
+FROM alpine:3
+# Define GOTRACEBACK to mark this container as using the Go language runtime
+# for `skaffold debug` (https://skaffold.dev/docs/workflows/debug/).
+ENV GOTRACEBACK=single
+CMD ["./app"]
+COPY --from=builder /app .