Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add code samples to v2 info sidebar #8119

Merged

Conversation

maggieneterval
Copy link
Contributor

Fixes: #6488

#7906 added the correct markup to both v1 and v2 docs, but only updated the v1 json file. This PR copies the json changes over to v2, so that the code samples are rendered on the v2 docs site.

@maggieneterval
Copy link
Contributor Author

@aaron-prindle Sorry for missing this in my initial CL!

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Np, thanks for the fix here!

@aaron-prindle aaron-prindle enabled auto-merge (squash) November 18, 2022 20:40
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #8119 (06a6615) into main (290280e) will decrease coverage by 4.25%.
The diff coverage is 53.26%.

@@            Coverage Diff             @@
##             main    #8119      +/-   ##
==========================================
- Coverage   70.48%   66.23%   -4.26%     
==========================================
  Files         515      599      +84     
  Lines       23150    29348    +6198     
==========================================
+ Hits        16317    19438    +3121     
- Misses       5776     8457    +2681     
- Partials     1057     1453     +396     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
... and 393 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit 865a51a into GoogleContainerTools:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs fixit] [technical writers review] [HaTS feedback] Pages should link to relevant github repo examples
2 participants