Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --tolerate-failures-until-deadline flag and deploy.tolerateFailuresUntilDeadline config for improved ci/cd usage #8047

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Nov 7, 2022

fixes #8032

NOTE: tested manually with deployment that failed for first 30 seconds and then succeeded based off of checking date output. Will add in a future PR a similar integration test to how this was manually tested

@aaron-prindle aaron-prindle changed the title feat: add --tolerate-failures-status-check flag and associated logic for improved ci/cd usage feat: add --tolerate-failures-status-check flag and deploy.tolerateFailures config for improved ci/cd usage Nov 7, 2022
@aaron-prindle aaron-prindle force-pushed the fix-8032 branch 4 times, most recently from fba5f93 to 9ee6cf3 Compare November 7, 2022 20:04
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #8047 (f6daddf) into main (290280e) will decrease coverage by 4.00%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #8047      +/-   ##
==========================================
- Coverage   70.48%   66.47%   -4.01%     
==========================================
  Files         515      597      +82     
  Lines       23150    29165    +6015     
==========================================
+ Hits        16317    19388    +3071     
- Misses       5776     8337    +2561     
- Partials     1057     1440     +383     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 396 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle force-pushed the fix-8032 branch 5 times, most recently from caff9fa to 2003762 Compare November 9, 2022 09:30
…FailuresUntilDeadline config for improved ci/cd usage
@ericzzzzzzz
Copy link
Contributor

tested with the following command,

skaffold dev --tolerate-failures-until-deadline=true -d=$test_repo --cache-artifacts=false

here is the result
Screen Shot 2022-11-09 at 8 11 57 AM

the implementation works as expected.

@ericzzzzzzz ericzzzzzzz self-requested a review November 9, 2022 13:15
@aaron-prindle aaron-prindle changed the title feat: add --tolerate-failures-status-check flag and deploy.tolerateFailures config for improved ci/cd usage feat: add --tolerate-failures-until-deadline flag and deploy.tolerateFailuresUntilDeadline config for improved ci/cd usage Nov 9, 2022
@aaron-prindle aaron-prindle merged commit 4b18279 into GoogleContainerTools:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants