Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skipTests to ignore helm test directory on manifest generation #8011

Merged

Conversation

imrenagi
Copy link
Contributor

Fixes: #5132

Description
This PR add new deploy.helm.releases[*].skipTests to the configuration file. This is to prevent skaffold from rendering the helm template located on tests directory.

User facing changes (remove if N/A)
User can skip helm tests when using helm to deploy the application.

apiVersion: skaffold/v3
kind: Config
metadata:
  name: waterfight
profiles:
 - name: helm
    deploy:
      helm:
        releases:
          - name: waterfight-skaffold-k8s
            chartPath: deployment/helm/app
            namespace: default
            skipTests: true

Signed-off-by: Imre Nagi imre.nagi@gojek.com

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #8011 (5bac4f3) into main (290280e) will decrease coverage by 3.87%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #8011      +/-   ##
==========================================
- Coverage   70.48%   66.61%   -3.88%     
==========================================
  Files         515      598      +83     
  Lines       23150    28986    +5836     
==========================================
+ Hits        16317    19308    +2991     
- Misses       5776     8252    +2476     
- Partials     1057     1426     +369     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 392 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imrenagi imrenagi force-pushed the feat/helm-skip-test branch from ea71002 to 5bac4f3 Compare November 4, 2022 03:59
@imrenagi
Copy link
Contributor Author

imrenagi commented Nov 4, 2022

hi @tejal29 can you please help review or assign reviewer for this PR? Thanks!

@aaron-prindle aaron-prindle self-requested a review November 4, 2022 05:44
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @imrenagi!

@aaron-prindle aaron-prindle merged commit f673fb9 into GoogleContainerTools:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm deployer is looking for a Helm test pod by default resulting in confusing warning text
2 participants