Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not print error message if it is empty #8005

Conversation

renzodavid9
Copy link
Contributor

Fixes: #7979

Description
With this PR we check first if an error message has a value before printing it so we don't get empty errors

Follow-up Work
Check other places where this could be happening

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #8005 (0d6d20a) into main (290280e) will decrease coverage by 3.76%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #8005      +/-   ##
==========================================
- Coverage   70.48%   66.71%   -3.77%     
==========================================
  Files         515      596      +81     
  Lines       23150    28897    +5747     
==========================================
+ Hits        16317    19279    +2962     
- Misses       5776     8195    +2419     
- Partials     1057     1423     +366     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 390 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle marked this pull request as ready for review November 1, 2022 20:39
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually confirmed this is working now using examples/helm-deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold v2.0.0 has an issue where error log messages are output when no error occurs
3 participants