Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect CLI flag in skaffold render #7664

Merged
merged 17 commits into from
Aug 2, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
offline set to true, then don't set namespace
  • Loading branch information
tejal29 committed Aug 2, 2022
commit f5332f687339e88d57437edba333a1c183240ec9
2 changes: 1 addition & 1 deletion pkg/skaffold/render/renderer/util/util.go
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ func GenerateHydratedManifests(ctx context.Context, out io.Writer, builds []grap
}
// TODO(tejaldesai) consult with cloud deploy team if namespaces can be set offline mode
// in case namespace is set on the skaffold render cli command.
if opts.Offline {
if !opts.Offline {
if manifests, err = manifests.SetNamespace(ns, rs); err != nil {
return nil, err
}