-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag that prints timestamps in skaffold logs. #5181
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5181 +/- ##
==========================================
- Coverage 72.39% 71.82% -0.58%
==========================================
Files 385 387 +2
Lines 13735 13928 +193
==========================================
+ Hits 9944 10004 +60
- Misses 3063 3190 +127
- Partials 728 734 +6
Continue to review full report at Codecov.
|
hey @jtzwu, thanks for opening this PR. Looks like there's a formatting issue here but that's a quick fix. You'll also need to run ./hack/generate-man.sh and commit the results to update our docs to reflect the added flag. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
Description
Adds a flag that add timestamps to the skaffold logs.
User facing changes (remove if N/A)
Before
After