Output config version in skaffold version #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
approved these changes
Nov 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 42.19% 42.18% -0.01%
==========================================
Files 96 96
Lines 4237 4238 +1
==========================================
Hits 1788 1788
- Misses 2275 2276 +1
Partials 174 174
Continue to review full report at Codecov.
|
r2d4
approved these changes
Nov 7, 2018
pkg/skaffold/version/version.go
Outdated
| ) | ||
|
|
||
| var version, gitCommit, gitTreeState, buildDate string | ||
| var platform = fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH) | ||
| var configVersion = latest.Version |
There was a problem hiding this comment.
why not just use latest.Version directly?
There was a problem hiding this comment.
ah yeah I was trying something else here originally, you're right I should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239