Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portforward for resources with hardcoded namespace #1223

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Oct 30, 2018

works for cases like

apiVersion: v1
kind: Pod
metadata:
  name: something
  namespace: something

@codecov-io
Copy link

Codecov Report

Merging #1223 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
+ Coverage   41.48%   41.49%   +0.01%     
==========================================
  Files          95       95              
  Lines        4233     4234       +1     
==========================================
+ Hits         1756     1757       +1     
  Misses       2307     2307              
  Partials      170      170
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/port_forward.go 37.63% <33.33%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71131fe...c55e88a. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r2d4 r2d4 merged commit 16e87c5 into GoogleContainerTools:master Oct 30, 2018
@r2d4 r2d4 deleted the namespace-in-yaml branch October 30, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants