Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed panic if skaffold.yaml is empty (#1216) #1221

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

varunkashyap
Copy link
Contributor

The absence of apiVersion from skaffold.yaml hadn't been tested, a
nil err was being sent to errors.Wrapf which then returned nil as error
leading to wrong success of configuration parse operation.

We are now creating a new error instead of relying on wraping a
potentially nil err with errors.Wrapf.

The absence of apiVersion from skaffold.yaml hadn't been tested, a
nil err was being sent to errors.Wrapf which then returned nil as error
leading to wrong success of configuration parse operation.

We are now creating a new error instead of relying on wraping a
potentially nil err with errors.Wrapf.
@codecov-io
Copy link

Codecov Report

Merging #1221 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
+ Coverage   41.41%   41.48%   +0.07%     
==========================================
  Files          95       95              
  Lines        4233     4233              
==========================================
+ Hits         1753     1756       +3     
+ Misses       2309     2307       -2     
+ Partials      171      170       -1
Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 64.86% <100%> (+8.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1731195...0ac028e. Read the comment docs.

@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2018
@r2d4 r2d4 merged commit 45127a7 into GoogleContainerTools:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants