Move structure tests out of getting-started example #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
+ Coverage 41.41% 41.49% +0.08%
==========================================
Files 95 95
Lines 4233 4234 +1
==========================================
+ Hits 1753 1757 +4
+ Misses 2309 2307 -2
+ Partials 171 170 -1
Continue to review full report at Codecov.
|
balopat
previously requested changes
Oct 30, 2018
r2d4
reviewed
Oct 31, 2018
| @@ -0,0 +1 @@ | |||
| /usr/local/google/home/nkubala/.cache/bazel/_bazel_nkubala/0b5f2432d049b24dd37a3f57ec8ef151/execroot/skaffold/bazel-out/k8-fastbuild/genfiles | |||
There was a problem hiding this comment.
integration/examples/bazel/bazel-* should be added to the gitignore and not checked in
There was a problem hiding this comment.
thanks for catching that!! I'll remove those.
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks for being the only person to actually run the integration tests locally :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154 and #1157