Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove project level skaffold.yaml #1119

Merged

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Oct 8, 2018

No description provided.

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\O/

@dgageot
Copy link
Contributor

dgageot commented Oct 8, 2018

Isn't that used for the release?

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #1119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1119   +/-   ##
=======================================
  Coverage   42.96%   42.96%           
=======================================
  Files          74       74           
  Lines        3403     3403           
=======================================
  Hits         1462     1462           
  Misses       1801     1801           
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64849...cabcee3. Read the comment docs.

@balopat
Copy link
Contributor Author

balopat commented Oct 8, 2018

No, it's not used for the release in my understanding.

@balopat balopat merged commit b809bd5 into GoogleContainerTools:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants