Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify schema versioning #1067

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 29, 2018

I tried to simplify the code as much as possible so that introducing new versions of the schema requires moving and copying fewer things around

Number of instances of v1alpha in the sources:
find . -name .go -not -path "./vendor/" -exec cat {} ; | grep -c v1alpha
BEFORE: 143
AFTER: 21

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Sep 29, 2018

Codecov Report

Merging #1067 into master will increase coverage by 0.78%.
The diff coverage is 48.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   41.22%   42.01%   +0.78%     
==========================================
  Files          72       71       -1     
  Lines        3134     3187      +53     
==========================================
+ Hits         1292     1339      +47     
- Misses       1710     1715       +5     
- Partials      132      133       +1
Impacted Files Coverage Δ
pkg/skaffold/build/gcb/cloud_build.go 0% <ø> (ø) ⬆️
pkg/skaffold/build/local/docker.go 21.05% <ø> (ø) ⬆️
pkg/skaffold/build/local/local.go 62.5% <ø> (ø) ⬆️
pkg/skaffold/deploy/helm.go 63.31% <ø> (ø) ⬆️
pkg/skaffold/build/local/bazel.go 0% <ø> (ø) ⬆️
pkg/skaffold/docker/image.go 59.18% <ø> (ø) ⬆️
pkg/skaffold/deploy/kubectl/cli.go 0% <ø> (ø) ⬆️
pkg/skaffold/build/gcb/desc.go 100% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/cmd.go 0% <ø> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 36.23% <ø> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a874e...7ce2b37. Read the comment docs.

@dgageot dgageot force-pushed the versionning branch 3 times, most recently from 8a15aaa to 12ab3ed Compare September 29, 2018 16:44
@dgageot dgageot added the wip label Sep 30, 2018
@dgageot dgageot removed the wip label Oct 2, 2018
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the simplifications, thank you very much!

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit bd3fc88 into GoogleContainerTools:master Oct 2, 2018
@dgageot dgageot deleted the versionning branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants