Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for watching Kustomize dependencies #1015

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

ajbouh
Copy link
Contributor

@ajbouh ajbouh commented Sep 21, 2018

This isn't a complete enumeration of Kustomize dependencies, but it's a reasonable initial step.

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #1015 into master will decrease coverage by 0.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
- Coverage   40.18%   39.84%   -0.35%     
==========================================
  Files          70       70              
  Lines        3041     3067      +26     
==========================================
  Hits         1222     1222              
- Misses       1693     1719      +26     
  Partials      126      126
Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7755b82...fd31ddc. Read the comment docs.

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding a few tests would be even better.

@r2d4 wdyt?

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup LGTM. Lets make sure to add an apiversion check when kustomize introduces one.

@r2d4
Copy link
Contributor

r2d4 commented Sep 22, 2018

Fixes #942

Thanks!

@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Sep 22, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 22, 2018
@ajbouh
Copy link
Contributor Author

ajbouh commented Sep 22, 2018

I felt bad about not writing tests or covering all the ways that kustomize can use external files, but this change made me so much more productive that I wanted to share it with others

@dgageot dgageot merged commit 1ba8da2 into GoogleContainerTools:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants