-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode disconnects from DevContainer when running skaffold build #9324
Comments
Found some errors in the docker daemon logs that occur every time i reproduce the error. Here they are, in case they are related to the issue:
|
Could narrow it down further, the issue only occurs when the environment variable Maybe templating has to do something with it? This log entry contains the environment variable:
|
Found the source of the problem, and skaffold is not at fault. Skaffold at some point causes the docker credential store to list all stored credentials. VSCode places a proxy credential store inside the devcontainer that should forward any calls to the host system. This works for get or store subcommands, but list crashes the VSCode extension host running inside the container. Can be reproduced by
I could confirm that the credential store on the host gets called correctly and return the correct json data, so the must be some bug in the VSCode devcontainer extension, so i will close this issue and open one in the VSCode repo. For anyone finding this, you can disable forwarding the credential store to the container until this is fixed with the following setting: |
@CaffeineDaemon Can you link to the issue you created? |
|
Expected behavior
skaffold build
can be run from inside a VSCode DevContainer without issues.Actual behavior
Running
skaffold build
disconnects VSCode from the container as soon as the docker image build starts:The container keeps running and the build finishes.
This does not happen when doing the same with VSCode connected directly to WSL2 or running the commands in the container through
docker exec
from another shell.Muting the shell output or piping it to a file does not prevent the disconnect.
Running
docker build
directly is not causing a disconnect.Information
Steps to reproduce the behavior
skaffold build --cache-artifacts=false
to force a docker buildLog Output:
The text was updated successfully, but these errors were encountered: