Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off Docker credential helper forwarding #8201

Closed
chrmarti opened this issue Mar 15, 2023 · 1 comment
Closed

Option to turn off Docker credential helper forwarding #8201

chrmarti opened this issue Mar 15, 2023 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers

Comments

@chrmarti
Copy link
Contributor

          I added some comments on this issue here for the same problem: https://github.com/microsoft/vscode-remote-release/issues/7982

I am worried that this "automatic" behaviour will conflict with various setups, as this current feature has forced me to downgrade the extension. If possible, could this auto-adding of the cred store be feature toggled in devcontainer.json? My team have the container set up so that the container itself negotiates required authentication to services so even if there IS a credential helper on the host we do not want the container using it.

Originally posted by @finite8 in #8096 (comment)

@chrmarti chrmarti self-assigned this Mar 15, 2023
@chrmarti chrmarti added this to the March 2023 milestone Mar 15, 2023
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers labels Mar 15, 2023
@chrmarti
Copy link
Contributor Author

This actually made it in with #7982 and is available in Dev Containers 0.278.0 and later:
image

@chrmarti chrmarti removed this from the March 2023 milestone Mar 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers
Projects
None yet
Development

No branches or pull requests

1 participant